#1947 Bundle Size — 10.59MiB (+0.04%).

4841133(current) vs 3fa3192 main#1945(baseline)

Bundle metrics   1 change

	Current #1947	Baseline #1945
Initial JS	1.86MiB	1.86MiB
Initial CSS	607.87KiB	607.87KiB
Cache Invalidation	18.18%	17.76%
Chunks	222	222
Assets	245	245
Modules	2873	2873
Duplicate Modules	146	146
Duplicate Code	1.84%	1.84%
Packages	95	95
Duplicate Packages	2	2

Bundle size by type   1 change 1 regression

	Current #1947	Baseline #1945
JS	8.78MiB (+0.05%)	8.78MiB
CSS	890.63KiB	890.63KiB
Fonts	526.1KiB	526.1KiB
Media	295.6KiB	295.6KiB
IMG	140.74KiB	140.74KiB
HTML	1.24KiB	1.24KiB
Other	871B	871B

Bundle analysis report Branch stefan-hoehn:blockly_getthings Project dashboard

Changing this would imply a complete reimplementation of the standard block which IMHO is not worth the effort.

I've noticed this too and agree. It's an unfortunate coincidence but I kind of blame OH for using the term "Item" the way it does in the first place instead of something less likely to conflict (Thing too). But since that choice was made long before even my time with OH, 🤷 .

re "Thing". I understand why Thing was used -> Internet of Things, so I am happy with that. Wording is always difficult, I suppose. I would rather have hoped that blockly had chosen "element" instead of item ;-)

@stefan-hoehn, thanks a lot for your work!

Two quick questions:

1. Maybe I misunderstand something or use things wrongly (I also couldn't answer it myself with the docu):
   
   Thr first two logging-blocks work with the new thing-loop, the third one throws an error.

2024-07-11 21:57:33.523 [ERROR] [script.javascript.thing_status_check] - Failed to execute script: TypeError: things.getThing is not a function
        at <js>.:program(<eval>:10)
        at org.graalvm.polyglot.Context.eval(Context.java:399)
        at com.oracle.truffle.js.scriptengine.GraalJSScriptEngine.eval(GraalJSScriptEngine.java:458)
        at com.oracle.truffle.js.scriptengine.GraalJSScriptEngine.eval(GraalJSScriptEngine.java:426)
        at java.scripting/javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:262)
        ... 75 more
2024-07-11 21:57:33.524 [ERROR] [internal.handler.ScriptActionHandler] - Script execution of rule with UID 'thing_status_check' failed: org.graalvm.polyglot.PolyglotException: TypeError: things.getThing is not a function

Am I using things wrongly? If yes, maybe others run into the same problem and this usage could be blocked in blockly?

2. With the powerful things-loop now being in place, would it make sense to be able to fire a rule if the status of any of the available things changes? The way I see the rule-trigger as of today, I can only trigger a rule if I select all things one-by-one. Is that correct?

For 1 I think you need to file a new issue. Be sure to also post the full rule from the code tab so we can see the XML that makes up the blocks, the JS that the blocks compiled to, and the full rule context.

For 2 see https://community.openhab.org/t/thing-status-reporting-4-0-0-0-4-9-9-9/143180. Ultimately adding a new trigger would be an issue for core but this rule template can be used as is or as an example for how to work with the generic rule trigger in UI rules.

For 1 I think you need to file a new issue. Be sure to also post the full rule from the code tab so we can see the XML that makes up the blocks, the JS that the blocks compiled to, and the full rule context.

Thanks. I just did here: #2670.
Let me know if I missed something that's needed as well.